[Webkit-unassigned] [Bug 100321] Refactor LLInt64 to distinguish the pointer operations from the 64-bit integer operations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100321





--- Comment #13 from Filip Pizlo <fpizlo at apple.com>  2012-10-24 22:20:10 PST ---
(In reply to comment #11)
> (In reply to comment #10)
> > (In reply to comment #9)
> > > Based on this, the line at x86.rb:56 should be change to test for isX64 as well like at line 251.  Isn't that right?  For 32-bit x86 (not x32), I would expect jmps and calls to use a 32bit ptr, not a quad.  Am I misunderstanding something?
> > 
> > Hi Mark, line 56 will be run only in X64 backend. It's guarded by line 40. Thanks.
> 
> Or, in other words, SpecialRegister should only be available in X64. Does this sound reasonable? Or we need to add another guard in this method? it's Ok for me to add the guard before landing if you think necessary. Thanks.

The reliance on SpecialRegister only existing in 64-bit is a little strange, but not strange enough for me to care.

R=me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.