[Webkit-unassigned] [Bug 94987] Add webkitHRTimeStamp to DOM events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=94987


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #170536|review?                     |review-
               Flag|                            |




--- Comment #24 from Adam Barth <abarth at webkit.org>  2012-10-24 19:26:25 PST ---
(From update of attachment 170536)
View in context: https://bugs.webkit.org/attachment.cgi?id=170536&action=review

Also you don't appear to have written any tests.  :(

> Source/WebKit/chromium/ChangeLog:8
> +        Adds a webkitSystemTime property to DOM events which exposes the platform event

webkitSystemTime <--- does this need to be updated?

> Source/WebCore/dom/Event.idl:65
> +#if defined(ENABLE_EVENT_SYSTEM_TIME)
> +    readonly attribute double           systemTime;
> +#endif

Should this be InitializedByEventConstructor ?

Please make this runtime enabled.

You don't need to use #if.  You can use the Conditional attribute.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.