[Webkit-unassigned] [Bug 100305] [BlackBerry] Geolocation is segfaulting

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100305


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #170508|review?                     |review+
               Flag|                            |




--- Comment #2 from Rob Buis <rwlbuis at gmail.com>  2012-10-24 16:40:01 PST ---
(From update of attachment 170508)
View in context: https://bugs.webkit.org/attachment.cgi?id=170508&action=review

Some things to fix still before landing.

> Source/WebKit/blackberry/WebCoreSupport/GeolocationClientBlackBerry.cpp:84
> +    return;

Please indent.

> Source/WebKit/blackberry/WebCoreSupport/GeolocationClientBlackBerry.cpp:87
> +    m_pendingPermissionGeolocation = RefPtr<Geolocation>(location);

Maybe you can leave off the RefPtr<Geolocation>.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.