[Webkit-unassigned] [Bug 100155] Full-page PDFPlugin should support inline form editing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100155





--- Comment #6 from Tim Horton <timothy_horton at apple.com>  2012-10-24 13:35:36 PST ---
(In reply to comment #5)
> I don’t think the term “inline PDF” is a thing. Do you mean PDFs used as images?

I meant "subframe PDFs"; I will fix the terminology.

> > Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:202
> > +        annotationContainer->setInlineStyleProperty(CSSPropertyOverflow, "hidden");
> > +        annotationContainer->setInlineStyleProperty(CSSPropertyPosition, "absolute");
> > +        annotationContainer->setInlineStyleProperty(CSSPropertyPointerEvents, "none");
> > +        annotationContainer->setInlineStyleProperty(CSSPropertyTop, 0.0, CSSPrimitiveValue::CSS_PX);
> > +        annotationContainer->setInlineStyleProperty(CSSPropertyLeft, 0.0, CSSPrimitiveValue::CSS_PX);
> > +        annotationContainer->setInlineStyleProperty(CSSPropertyRight, 0.0, CSSPrimitiveValue::CSS_PX);
> > +        annotationContainer->setInlineStyleProperty(CSSPropertyBottom, 0.0, CSSPrimitiveValue::CSS_PX);
> 
> Is this more efficient than setting a hardcoded style attribute string? Doing that would avoid the need to cast to StyledElement* and cut down a lot on the lines of code.

I've put what I can in a <style> attached to the animation container. Not sure if I should put that in a separate file, right now it's just constructed from a static string in PDFPlugin.mm.

> > Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginAnnotation.h:57
> > +    virtual void updateGeometry();
> > +    virtual void commit() = 0;
> 
> Can these be private or protected?

They can't be private, as PDFPlugin needs to call them! Is there a reason to make them protected and make PDFPlugin a friend of PDFPluginAnnotation rather than leaving them public? I've not heard any clear policy here.

> > Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginAnnotation.h:70
> > +    virtual PassRefPtr<WebCore::Element> createAnnotationElement() = 0;
> 
> Can this be private instead of protected?

Yep.

> > Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginAnnotation.h:83
> > +         bool operator==(const EventListener& listener) OVERRIDE { return this == &listener; }
> 
> Need virtual keyword here.

Weird! I thought override complained when the method wasn't virtual. Weird weird weird.

New patch shortly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.