[Webkit-unassigned] [Bug 98215] webkit-patch optimize-baselines thinks it's succeeding, but it's not

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98215





--- Comment #3 from Dirk Pranke <dpranke at chromium.org>  2012-10-24 12:07:57 PST ---
(In reply to comment #2)
> (In reply to comment #1)
> > (In reply to comment #0)
> > > All the -expected.txt are the same except the platform/mac one matches the chromium virtual/gpu one. So, since everyone falls back to platform/mac, we can't do better except the chromium -expected.txt results should all go in platform/chromium.
> > 
> > By stating 'since everyone falls back to platform/mac', do you mean the GTK baselines as well? If so, that's not correct.
> 
> I misspoke. I think now only Apple ports fallback to platform/mac.
>

Right, so I'm not sure you're reporting a real bug here. 

> > r132121[1] has removed GTK baselines for svg/transforms/svg-css-transforms-clip-path.html and svg/transforms/svg-css-transforms-clip-path.html tests probably because the text baselines match the baselines in platform/mac. However, the GTK port in NRWT doesn't then fall back to these Mac baselines and the tests were being reported as missing results.
> 
> Ugh. That's not good. :(

This, however, I think is a real bug. I've noticed this too in some of my chromium mountain lion rebaselining; I had assumed that there were generic -expected files that were redundant with the gtk files, but I am sad to say I didn't actually verify this. I will dig into it more.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.