[Webkit-unassigned] [Bug 100145] [BlackBerry] Extending existing ThreadUnsafe singletons in webkit to Generic ThreadUnsafe Singleton

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100145


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #170391|review?                     |review-
               Flag|                            |




--- Comment #4 from Rob Buis <rwlbuis at gmail.com>  2012-10-24 07:41:19 PST ---
(From update of attachment 170391)
View in context: https://bugs.webkit.org/attachment.cgi?id=170391&action=review

Please fix the Changelogs.

> Source/WebCore/ChangeLog:7
> +        Reviewed by: Yong Li.

This is ot how we do it. It is better to keep the original Reviewed by (OOPS)!!! line here. What you should do is an extra line with "Reviewed internally by XXX". Have a look at our other commits.

> Source/WebCore/ChangeLog:12
> +        https://przilla.ott.qnx.com/bugzilla/show_bug.cgi?id=214384

You can just abbreviate to PR214384.

> Source/WebKit/blackberry/ChangeLog:7
> +        Reviewed by: Yong Li.

Ditto.

> Source/WebKit/blackberry/ChangeLog:12
> +        https://przilla.ott.qnx.com/bugzilla/show_bug.cgi?id=214384

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.