[Webkit-unassigned] [Bug 96602] -ldl should not be hardcoded into OPENGL_LIBS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96602


Xan Lopez <xan.lopez at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #170343|review?                     |review-
               Flag|                            |




--- Comment #5 from Xan Lopez <xan.lopez at gmail.com>  2012-10-24 02:14:03 PST ---
(From update of attachment 170343)
View in context: https://bugs.webkit.org/attachment.cgi?id=170343&action=review

> configure.ac:282
> +AC_SUBST([DLOPEN_LIBS])

This makes sense, but would you mind adding a small comment saying what it does? Mostly because it's checking for the uncommon case (BSD-ish systems), so it's possible that a maintainer will be confused in the future. Something like:

"We check whether dlopen is in the core libraries; if it's not we pull in libdl if it has dlopen and is available, as it's needed in GNU/Linux."

Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.