[Webkit-unassigned] [Bug 99315] Add GTK+ API to set a WebKitWebView in view source mode to WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99315


Mario Sanchez Prada <mario at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com,
                   |                            |mario at webkit.org




--- Comment #6 from Mario Sanchez Prada <mario at webkit.org>  2012-10-24 01:22:50 PST ---
(In reply to comment #5)
> > [...]
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:647:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> > Total errors found: 6 in 12 files
> 
> I don't think we should introduce new style errors, if we can help it. :/

There seems to be an (not solved yet) issue with the current implementation of check-webkit-style, as it's not 100% clear whether the current behavior (implemented as a patch for bug 97602 [1]) is the right one or not.

I've posted a comment in the bug originating the confusion [2] and we are currently waiting for Darin (added now to CC) for clarifying this before proceeding either with fixing the check-webkit-style script or to adopt the new style for GTK code too (as I agree making exceptions is probably not the best solution).

For the time being, and even if I agree it's weird to ignore these errors, I'd lean more towards ignoring them since it was the way we used to code until now, and I'm not sure it's wise to embrace the new style without a clear statement saying that it's the right one (and at the moment such a statement hasn't happened yet, there's only some confusion :))

My 2 cents to unblock these situations.

[1]https://bugs.webkit.org/show_bug.cgi?id=97602
[2]https://bugs.webkit.org/show_bug.cgi?id=95930#c22

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.