[Webkit-unassigned] [Bug 99836] [GTK] Add API to get the WebKitWebView associated to a WebKitDownload to WebKit2 GTK+

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99836


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #169614|review?                     |review+
               Flag|                            |




--- Comment #5 from Martin Robinson <mrobinson at webkit.org>  2012-10-23 18:29:04 PST ---
(From update of attachment 169614)
View in context: https://bugs.webkit.org/attachment.cgi?id=169614&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:295
> + * start a download from a particular #WebKitWebView use

Nit: start -> starting

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:993
> +void webkitWebViewBaseSetDownloadRequestHandler(WebKitWebViewBase* webViewBase, WebKitWebViewBaseDownloadRequestHandler downloadHandler)
> +{
> +    webViewBase->priv->downloadHandler = downloadHandler;
> +}
> +
> +void webkitWebViewBaseHandleDownloadRequest(WebKitWebViewBase* webViewBase, DownloadProxy* download)
> +{
> +    if (webViewBase->priv->downloadHandler)
> +        webViewBase->priv->downloadHandler(webViewBase, download);
> +}

I guess this is to avoid exposing any API in the base class. I think we should think seriously about just getting rid of WebKitWebViewBase before the stable release.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.