[Webkit-unassigned] [Bug 98989] [CSS Shaders] Add CustomFilterRenderer to reuse this class by Accelerated Compositing.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98989





--- Comment #16 from Max Vujovic <mvujovic at adobe.com>  2012-10-23 14:45:16 PST ---
(From update of attachment 170234)
View in context: https://bugs.webkit.org/attachment.cgi?id=170234&action=review

> Source/WebCore/platform/graphics/filters/CustomFilterRenderer.cpp:79
> +CustomFilterRenderer::CustomFilterRenderer(PassRefPtr<GraphicsContext3D> context, PassRefPtr<CustomFilterValidatedProgram> validatedProgram, const CustomFilterProgramInfo&, const CustomFilterParameterList& parameters,

Do we need to pass in CustomFilterProgramInfo separately? Can ask for validatedProgram->programInfo() instead?

> Source/WebCore/platform/graphics/filters/CustomFilterRenderer.cpp:97
> +    return m_validatedProgram->programInfo().programType() == PROGRAM_TYPE_BLENDS_ELEMENT_TEXTURE;

Like this.

> Source/WebCore/platform/graphics/filters/FECustomFilter.cpp:47
> +FECustomFilter::FECustomFilter(Filter* filter, PassRefPtr<GraphicsContext3D> context, PassRefPtr<CustomFilterValidatedProgram> validatedProgram, const CustomFilterProgramInfo& programInfo, const CustomFilterParameterList& parameters,

Ditto regarding CustomFilterProgramInfo.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.