[Webkit-unassigned] [Bug 55402] loaderRunLoop() should use synchronization instead of while loop

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 23 03:47:13 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=55402





--- Comment #17 from Jae Hyun Park <jae.park at company100.net>  2012-10-23 03:48:17 PST ---
(In reply to comment #14)
> (In reply to comment #11)
> > Attachment 169572 [details] [details] did not pass style-queue:
> > 
> > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
> > Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp:54:  Use 0 or null instead of NULL (even in *comments*).  [readability/null] [4]
> > Total errors found: 1 in 2 files
> > 
> > 
> > If any of these errors are false positives, please file a bug against check-webkit-style.
> 
> I know this is in code that just moved around but you might as well fix this style error to keep the bot happy.

Thanks for the review. I fixed it in the new patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list