[Webkit-unassigned] [Bug 90755] Remove down-casting to BitmapImage in GraphicsContext::drawImage.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90755





--- Comment #6 from Huang Dongsung <luxtella at company100.net>  2012-10-22 19:35:54 PST ---
(In reply to comment #5)
> How does this patch work? Before this patch, BitmapImage::draw would be called from GraphicsContext.cpp, which had an implementation that honored the image orientation in ImageCG.cpp (BitmapImage::draw()).
> 
> Now GraphicsContext calls Image::draw() on all platforms, which always throws away the orientation parameter. How does this patch not break image orientation on mac?

That's good question.

BitmapImage of mac only overrides Image::draw(). BitmapImage of other ports does not overrides Image::draw().

#if USE(CG)
    virtual void draw(GraphicsContext*, const FloatRect& dstRect, const FloatRect& srcRect, ColorSpace styleColorSpace, CompositeOperator, RespectImageOrientationEnum);
#endif

It means in mac if you call draw() of BitmapImage, Image::draw() is not called and BitmapImage::draw() of mac is called, which does not throw away the orientation parameter.

Please let me know if you have questions anymore :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.