[Webkit-unassigned] [Bug 45110] Implement JSC features required for IndexedDB

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45110





--- Comment #44 from Joshua Bell <jsbell at chromium.org>  2012-10-22 14:23:50 PST ---
(From update of attachment 169813)
View in context: https://bugs.webkit.org/attachment.cgi?id=169813&action=review

> Source/WebCore/Modules/indexeddb/IDBCursor.cpp:149
> +        RefPtr<IDBKey> keyPathKey = createIDBKeyFromScriptValueAndKeyPath(context, value, keyPath);

These changes look complimentary to the patch over in https://bugs.webkit.org/show_bug.cgi?id=99975 - watch for collisions.

> Source/WebCore/Modules/indexeddb/IDBCursorWithValue.idl:30
> +    [V8CustomGetter, JSCustomGetter, CachedAttribute] readonly attribute IDBAny value;

Does CachedAttribute gain anything here? In the V8 case the V8CustomGetter is used as CachedAttribute doesn't let us "dirty" the values.

(As an alternative approach, I was pondering having IDBCursor's properties be "any" in the IDL and just a ScriptValue in the C++, but haven't played with that yet.)

> Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp:105
> +    const IDBIndexMetadata& indexMetadata,

Indentation here is odd.

> Source/WebCore/bindings/js/SerializedScriptValue.cpp:1845
> +    if (m_data.size() & 1) {

Looks like a similar fix to https://bugs.webkit.org/show_bug.cgi?id=99310

Include the test case?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.