[Webkit-unassigned] [Bug 99658] Crash when trying to write exception message to null console

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99658





--- Comment #10 from Toni Barzic <tbarzic at chromium.org>  2012-10-22 13:27:08 PST ---
(From update of attachment 169745)
View in context: https://bugs.webkit.org/attachment.cgi?id=169745&action=review

>> Source/WebCore/ChangeLog:8
>> +        
> 
> You've got an extra blank line here.

Done.

>> Source/WebCore/ChangeLog:13
>> +
> 
> This blank line is also extra.

Done.

>> LayoutTests/ChangeLog:3
>> +        Regression test for 
> 
> Usually we just have the bug title here, like in the WebCore ChangeLog entry

Done.

>> LayoutTests/ChangeLog:10
>> +        Unfortuantelly, the test is inherently flaky and may produce some false positive results (but should never fail if there is no bug).
> 
> typo: Unfortuantelly

Done.

>> LayoutTests/fast/workers/worker-exception-during-navigation.html:10
>> +}
> 
> Please use the gc.js file that has this logic rather than copy/pasting it here.

Done.

>> LayoutTests/fast/workers/worker-exception-during-navigation.html:19
>> +        }, 100);
> 
> Why 100?

To give the test enough time to crash. Added comment.

>>> LayoutTests/fast/workers/worker-exception-during-navigation.html:32
>>> +    for (var i = 0; i< 500; i++) {
>> 
>> 500 workers!  Oh my.
> 
> Also, we're missing a space before the <

yeah, I reduced the number of workers (I planned to do this all along, but didn't manage on Friday)

the test is still kinda funky, but I can't think of a better way to test this :(

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.