[Webkit-unassigned] [Bug 99975] Remove ensureAuxiliaryContext

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99975


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #169867|review?                     |review-
               Flag|                            |




--- Comment #4 from Adam Barth <abarth at webkit.org>  2012-10-22 08:46:52 PST ---
(From update of attachment 169867)
View in context: https://bugs.webkit.org/attachment.cgi?id=169867&action=review

> Source/WebCore/bindings/v8/V8Binding.cpp:313
> +v8::Local<v8::Context> toV8Context(ScriptExecutionContext* context)

This function is too tempting for people to call, but it will often give the wrong result.  The problem is that you don't know which worlds context you want to return, especially if there is not JavaScript on the stack.  That's why the other version of this function requires a world context handle.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.