[Webkit-unassigned] [Bug 99850] [EFL][WK2] Use the port independent PageViewportController

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 22 08:19:46 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=99850





--- Comment #9 from Yael <yael.aharon.m at gmail.com>  2012-10-22 08:20:47 PST ---
(In reply to comment #6)
Thanks for your comments :)
> (From update of attachment 169748 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=169748&action=review
> 
> The general direction looks good. Also let me know if you think something is missing from the client API.
> 
> > Source/WebKit2/UIProcess/API/efl/PageViewportControllerClientEfl.cpp:100
> > +        ViewportUpdateDeferrer deferrer(m_pageViewportController);
> 
> I'm in the process of removing the ViewportUpdateDeferrer because with the current implementation of PageViewportContrloller its purpose for Qt is not present any more. This code should be changed not to need the deferrer either.
Thanks for letting me know about removing the deferrer class.
I only added it because it triggers setting some flags in PageViewController. Once you remove the class, I'll adjust my implementation.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list