[Webkit-unassigned] [Bug 98990] [Texmap][CSS Shaders] Enable CSS Shaders in TextureMapperGL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98990





--- Comment #11 from Noam Rosenthal <noam.rosenthal at nokia.com>  2012-10-22 07:36:51 PST ---
(In reply to comment #8)
> (In reply to comment #7)
> > How about a pattern similar to adoptImageBackingStore/releaseImageBackingStore, where LayerTreeCoordinator tracks which custom filter programs are actually in use, and sends separate messages to the proxy to create/destroy them?
> 
> Good suggestion for the purpose of TextureMapper holding CustomFilterGlobalContext and CustomFilterRenderer.
> 
> However, if we make LayerTreeCoordinator track which custom filter programs are actually in use, we must implement similar code in PageClientQt and AcceleratedCompositingContextGL. IMHO this way which we introduce to reduce complexity may be more complex than previous way (TextureMaperLayer holds CustomFilterRenderer).
> On the other hands, I think it is natural for TextureMaperLayer to hold CustomFilterRenderer like RenderLayer. When readers compares the difference of css shaders implementation between software path and TexMap, the approach of this patch helps readers understand easily.
> 
> I'm looking forward your feedback again :)

OK, another option.
TextureMapperLayer will ref/deref the use of a CustomFilterProgram in a function called from flushCompositingState, when it knows which new filters its receiving. This would be equivalent to how stuff is done in WebCore. The shared context itself will be held inside TextureMapper, but the filters will arrive to the paint functions already prepared during the flush phase.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.