[Webkit-unassigned] [Bug 98990] [Texmap][CSS Shaders] Enable CSS Shaders in TextureMapperGL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98990





--- Comment #10 from Huang Dongsung <luxtella at company100.net>  2012-10-22 01:41:07 PST ---
(From update of attachment 169766)
View in context: https://bugs.webkit.org/attachment.cgi?id=169766&action=review

>> Source/WebCore/platform/graphics/filters/CustomFilterGlobalContext.cpp:95
>> +    }
> 
> Why not avoid the expensive call to GraphicsContext3D::create if m_context is already set?

Thanks for review.

CustomFilterGlobalContext::prepareContextIfNeeded(HostWindow* hostWindow) already returns without calling GraphicsContext3D::create if m_context is already set.

void CustomFilterGlobalContext::prepareContextIfNeeded(HostWindow* hostWindow)
{
    if (m_context.get())
        return;
    ....
}

In addition, prepareContextIfNeeded(HostWindow* hostWindow) has existed already and only software path uses this method.
TexMap uses prepareContextIfNeeded(PassRefPtr<GraphicsContext3D> context).

Please let me know if you have any concerns more :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.