[Webkit-unassigned] [Bug 98990] [Texmap][CSS Shaders] Enable CSS Shaders in TextureMapperGL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98990





--- Comment #9 from Simon Hausmann <hausmann at webkit.org>  2012-10-21 22:59:10 PST ---
(From update of attachment 169766)
View in context: https://bugs.webkit.org/attachment.cgi?id=169766&action=review

> Source/WebCore/platform/graphics/filters/CustomFilterGlobalContext.cpp:95
> -    m_context = GraphicsContext3D::create(attributes, hostWindow, GraphicsContext3D::RenderOffscreen);
> -    if (!m_context)
> +    RefPtr<GraphicsContext3D> context = GraphicsContext3D::create(attributes, hostWindow, GraphicsContext3D::RenderOffscreen);
> +    if (!context)
>          return;
> +    prepareContextIfNeeded(context.release());
> +}
> +
> +void CustomFilterGlobalContext::prepareContextIfNeeded(PassRefPtr<GraphicsContext3D> context)
> +{
> +    ASSERT(context.get());
> +    if (m_context.get()) {
> +        ASSERT(m_context.get() == context.get());
> +        return;
> +    }

Why not avoid the expensive call to GraphicsContext3D::create if m_context is already set?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.