[Webkit-unassigned] [Bug 88606] [Shadow DOM] Needs @host rule for ShadowDOM styling

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88606





--- Comment #49 from Hajime Morrita <morrita at google.com>  2012-10-21 18:06:48 PST ---
> >> Source/WebCore/css/StyleResolver.h:34
> >> +#include "StyleScopeResolver.h"
> > 
> > Can we eliminate this?
> 
> I need StyleScopeResolver.h because addHostRule() and ensureScopeResolver() defined in StyleResolver.h need information about StyleScopeResolver. i.e.
> adoptPtr(new StyleScopeResolver()) and ensureScopeResolver()->addHostRule(...).
> Is it better to move these implementation into StyleResolver.cpp?

I think so. addHostRule() is guarded by isHost() thus won't be hot.

--- Comment #50 from Hajime Morrita <morrita at google.com>  2012-10-21 18:06:49 PST ---
> >> Source/WebCore/css/StyleResolver.h:34
> >> +#include "StyleScopeResolver.h"
> > 
> > Can we eliminate this?
> 
> I need StyleScopeResolver.h because addHostRule() and ensureScopeResolver() defined in StyleResolver.h need information about StyleScopeResolver. i.e.
> adoptPtr(new StyleScopeResolver()) and ensureScopeResolver()->addHostRule(...).
> Is it better to move these implementation into StyleResolver.cpp?

I think so. addHostRule() is guarded by isHost() thus won't be hot.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.