[Webkit-unassigned] [Bug 99101] [EFL][WK2] Rename EflViewportHandler to PageViewportControllerClientEfl

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 21 05:05:12 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=99101





--- Comment #16 from Yael <yael.aharon.m at gmail.com>  2012-10-21 05:06:10 PST ---
(In reply to comment #15)
> (From update of attachment 169606 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=169606&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/PageViewportControllerClientEfl.cpp:40
> > +EflViewportHandler::EflViewportHandler(Evas_Object* viewWidget)
> 
> Shouldn't we rename these as well? :)
> 
> > Source/WebKit2/UIProcess/API/efl/PageViewportControllerClientEfl.h:27
> > +#ifndef EflViewportHandler_h
> > +#define EflViewportHandler_h
> 
> And these?

The patch contains 2 versions of each file. One is an identical copy of the old file, and one is my modifications. You are looking at the copy which is identical to the old file, not at my modifications.
Please have a look at comment #2 and comment #3 .

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list