[Webkit-unassigned] [Bug 99850] [EFL][WK2] Use the port independent PageViewportController

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99850





--- Comment #3 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2012-10-21 02:57:49 PST ---
(From update of attachment 169748)
View in context: https://bugs.webkit.org/attachment.cgi?id=169748&action=review

> Source/WebKit2/UIProcess/WebPageProxy.messages.in:76
> +#if PLATFORM(QT) || PLATFORM(EFL) && USE(COORDINATED_GRAPHICS)

Maybe we should have a different define?

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:281
> +static Evas_Coord_Point adjustedPointForScaling(Evas_Coord_Point point, Ewk_View_Private_Data* priv)

Can't we follow Qt naming?

QPointF QQuickWebView::mapToWebContent(const QPointF& pointInViewCoordinates) const
QRectF QQuickWebView::mapRectToWebContent(const QRectF& rectInViewCoordinates) const

Also I would add priv before point as it is a hard requirement

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.