[Webkit-unassigned] [Bug 99908] [CSS Shaders] Set FilterOperations on GraphicsLayer after the program of CSS Shaders is loaded.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99908





--- Comment #3 from Huang Dongsung <luxtella at company100.net>  2012-10-20 20:05:22 PST ---
(In reply to comment #2)
> (From update of attachment 169759 [details])
> This seems like a platform specific behavior - when we set the filters on a particular GraphicsLayer (e.g. CoordinatedGraphicsLayer) we can subscribe to the program as a client and reset the filters when the program is loaded.

Thanks for good opinion.

We already subscribe to the program when the program is loaded, because WebCore recalculates the style when the program is loaded.

I think both approaches can be right. Each GraphicsLayer easily resets the filters, but I prefer this patch because of two reasons.
1. Each platform needs to have similar code to handle unloaded programs.
2. As I mentioned in Changelog, RenderLayerBacking::updateImageContents() already waits calling GraphicsLayer::setContentsToImage() until an image is fully loaded. I want RenderLayerBacking to handle CachedProgram similar to CachedImage. I think same policy increases code readability.

I'm looking forward your feedback :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.