[Webkit-unassigned] [Bug 99658] Crash when trying to write exception message to null console
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 19 23:48:28 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=99658
--- Comment #7 from Adam Barth <abarth at webkit.org> 2012-10-19 23:49:25 PST ---
(From update of attachment 169745)
View in context: https://bugs.webkit.org/attachment.cgi?id=169745&action=review
> Source/WebCore/ChangeLog:8
> +
You've got an extra blank line here.
> Source/WebCore/ChangeLog:13
> +
This blank line is also extra.
> LayoutTests/ChangeLog:3
> + Regression test for
Usually we just have the bug title here, like in the WebCore ChangeLog entry
> LayoutTests/ChangeLog:10
> + Unfortuantelly, the test is inherently flaky and may produce some false positive results (but should never fail if there is no bug).
typo: Unfortuantelly
> LayoutTests/fast/workers/worker-exception-during-navigation.html:10
> +function gc()
> +{
> + if (window.GCController)
> + return GCController.collect();
> +
> + for (var i = 0; i < 10000; i++) { // > force garbage collection (FF requires about 9K allocations before a collect)
> + var s = new String("abc");
> + }
> +}
Please use the gc.js file that has this logic rather than copy/pasting it here.
> LayoutTests/fast/workers/worker-exception-during-navigation.html:19
> + }, 100);
Why 100?
> LayoutTests/fast/workers/worker-exception-during-navigation.html:32
> + for (var i = 0; i< 500; i++) {
500 workers! Oh my.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list