[Webkit-unassigned] [Bug 55402] loaderRunLoop() should use synchronization instead of while loop
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 19 11:20:14 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=55402
--- Comment #13 from Pratik Solanki <psolanki at apple.com> 2012-10-19 11:21:10 PST ---
(In reply to comment #12)
> (From update of attachment 169572 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=169572&action=review
>
> > Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp:41
> > +static Mutex mutex;
> > +static ThreadCondition threadCondition;
>
> These have constructors and destructors, and would break Mac build if compiled it. I think that ports that use LoaderRunLoopCF.cpp also don't want that.
So is the solution to have static methods that return Mutex/ThreadCondition ? i.e. something like
static Mutex& loaderRunLoopMutex()
{
static Mutex mutex;
return mutex;
}
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list