[Webkit-unassigned] [Bug 99852] Gstreamer 1.0 not working

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99852





--- Comment #5 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk>  2012-10-19 11:16:10 PST ---
(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 169644 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=169644&action=review
> > 
> > >> Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp:-91
> > >> -    ASSERT(!ptr || !gstObjectIsFloating(GST_OBJECT(ptr)));
> > > 
> > > You should not get rid of the entire assert no? Testing pointer nullity is still valid to me.
> > 
> > +1
> 
> ok.
> 

Sorry I answered too fast. No the !ptr check is not valid, this is a OR. It is there only to prevent calling GST_OBJECT() with a NULL pointer. It's totally fine to store NULL in the GRefPtr.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.