[Webkit-unassigned] [Bug 99852] Gstreamer 1.0 not working

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99852





--- Comment #4 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk>  2012-10-19 11:12:33 PST ---
(In reply to comment #3)
> (From update of attachment 169644 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=169644&action=review
> 
> >> Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp:-91
> >> -    ASSERT(!ptr || !gstObjectIsFloating(GST_OBJECT(ptr)));
> > 
> > You should not get rid of the entire assert no? Testing pointer nullity is still valid to me.
> 
> +1

ok.

> 
> > Source/WebCore/platform/graphics/gstreamer/GStreamerVersioning.cpp:-46
> > -    GstCaps* caps = gst_pad_get_current_caps(pad);
> > -    if (!caps)
> > -        caps = gst_pad_query_caps(pad, 0);
> > -    return adoptGRef(caps); // gst_pad_query_caps and gst_pad_get_current_caps return a new reference.
> 
> gst_pad_get_current_caps() can return NULL AFAIK. What should we do in that case instead of querying the caps to the pad?

Nothing, 0.10 GST_PAD_CAPS() macro you can also return NULL and this is handled gracefully by callers (by not painting).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.