[Webkit-unassigned] [Bug 99660] toggle FPS counter option
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 19 10:59:03 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=99660
--- Comment #9 from egraether at chromium.org 2012-10-19 10:59:58 PST ---
(In reply to comment #7)
> (From update of attachment 169310 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=169310&action=review
>
> > Source/WebCore/page/ChromeClient.h:367
> > + virtual void setShowFPSCounter(bool show) { }
>
> Given this is only called by inspector, I think it would be better to plumb it through InspectorClient.
I will have a look at this.
> > Source/WebKit/chromium/src/WebViewImpl.cpp:3939
> > + // NOTE: disabled for 'show FPS counter' option in WebInspector
> > + // if (layerTreeViewSettings.showFPSCounter || layerTreeViewSettings.showPlatformLayerTree) {
>
> Please remove the code instead of commenting it out.
I agree, this was just temporary. It is solved in a different way in the new Patch, assuring that the fontAtlas is only loaded when used.
Thank you for your remarks.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list