[Webkit-unassigned] [Bug 99751] PageViewportController::m_rawAttributes.devicePixelRatio is not initialized

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99751





--- Comment #7 from Andras Becsi <abecsi at webkit.org>  2012-10-19 05:27:51 PST ---
(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > (From update of attachment 169458 [details] [details] [details])
> > > View in context: https://bugs.webkit.org/attachment.cgi?id=169458&action=review
> > > 
> > > > Source/WebKit2/UIProcess/PageViewportController.cpp:74
> > > > +    m_rawAttributes.devicePixelRatio = 1;
> > > 
> > > ARgh, this device pixel ratio should be removed from here instead and we should use Page::deviceScaleFactor like everyone else
> > 
> > Since the recent refactor, we do not use m_rawAttributes.devicePixelRatio any more, so this patch does not really have an effect.
> > 
> > I'll prepare a patch to remove it from the attributes.
> 
> Well, without this patch, I saw a black screen in my version of EFL MIniBrowser, after hooking it up with PageViewController.
> The reason was that the zoom level was infinity.
> 
> m_rawAttributes.devicePixelRatio is actually used in computeMinimumScaleFactorForContentContained (ViewportAgruments.cpp)

Yes, you are right restrictMinimumScaleFactorToViewportSize and computeMinimumScaleFactorForContentContained could be called before didChangeViewportAttributes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.