[Webkit-unassigned] [Bug 99101] [EFL][WK2] Rename EflViewportHandler to PageViewportControllerClientEfl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99101





--- Comment #5 from Yael <yael.aharon.m at gmail.com>  2012-10-18 18:40:37 PST ---
(In reply to comment #4)
Thanks for your review :)
> (From update of attachment 169410 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=169410&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:119
> > +    OwnPtr<PageViewportControllerClientEfl> viewportHandler;
> 
> Don't you need to change variable name according to new class name ?
> 
Yes, I'll do that.
> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:120
> > +    OwnPtr<PageViewportController> pageViewportController;
> 
> What is purpose of pageViewportController ? It looks this member variable is not used in this patch.
After renaming this class, it now becomes a client of PageViewportController, so I added pageViewportController, since it doesn't make sense to have a client without the class it is client of.
Subsequent patches will make use of pageViewportController. 
If you feel that pageViewportController should be added later, I can remove it from this patch and add it in a later patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.