[Webkit-unassigned] [Bug 55402] loaderRunLoop() should use synchronization instead of while loop

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55402





--- Comment #5 from Jae Hyun Park <jae.park at company100.net>  2012-10-18 18:36:00 PST ---
(In reply to comment #3)
Thanks for the review.

> (From update of attachment 169508 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=169508&action=review
> 
> Thanks for working on this bug. I don't think its quite right though. Have you tested on a platform that uses this file i.e. Windows?
No, I haven't. But is there a difference in using threading primitives according to the platforms?
> 
> > Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp:73
> > -        while (!loaderRunLoopObject) {
> > -            // FIXME: <http://webkit.org/b/55402> - loaderRunLoop() should use synchronization instead of while loop
> > -#if PLATFORM(WIN)
> > -            Sleep(10);
> > -#else
> > -            struct timespec sleepTime = { 0, 10 * 1000 * 1000 };
> > -            nanosleep(&sleepTime, 0);
> > -#endif
> > -        }
> > +        m_threadCondition.wait();
> 
> Does this even compile? ThreadCondition::wait() takes a Mutex& as an argument.
Fixed it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.