[Webkit-unassigned] [Bug 55402] loaderRunLoop() should use synchronization instead of while loop

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55402





--- Comment #3 from Pratik Solanki <psolanki at apple.com>  2012-10-18 17:36:28 PST ---
(From update of attachment 169508)
View in context: https://bugs.webkit.org/attachment.cgi?id=169508&action=review

Thanks for working on this bug. I don't think its quite right though. Have you tested on a platform that uses this file i.e. Windows?

> Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp:73
> -        while (!loaderRunLoopObject) {
> -            // FIXME: <http://webkit.org/b/55402> - loaderRunLoop() should use synchronization instead of while loop
> -#if PLATFORM(WIN)
> -            Sleep(10);
> -#else
> -            struct timespec sleepTime = { 0, 10 * 1000 * 1000 };
> -            nanosleep(&sleepTime, 0);
> -#endif
> -        }
> +        m_threadCondition.wait();

Does this even compile? ThreadCondition::wait() takes a Mutex& as an argument.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.