[Webkit-unassigned] [Bug 99705] [GTK] Use custom private macros to define GObjects

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99705





--- Comment #5 from Martin Robinson <mrobinson at webkit.org>  2012-10-18 12:31:58 PST ---
(From update of attachment 169422)
View in context: https://bugs.webkit.org/attachment.cgi?id=169422&action=review

Nice work, but until we establish an exception for GTK code for code indenting, I think we should just follow the style rules. 

>> Source/WebKit2/UIProcess/API/gtk/WebKitGeolocationPermissionRequest.cpp:47
>> +WEBKIT_DEFINE_TYPE_WITH_CODE(WebKitGeolocationPermissionRequest, webkit_geolocation_permission_request, G_TYPE_OBJECT,
> 
> Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]

Please follow the style rule here.

>> Source/WebKit2/UIProcess/API/gtk/WebKitPrivate.h:69
>> +#define WEBKIT_DEFINE_TYPE(TN, t_n, T_P) _WEBKIT_DEFINE_TYPE_EXTENDED(TN, t_n, T_P, 0, {})
> 
> Missing space inside { }.  [whitespace/braces] [5]

Instead of using variable names like TN, t_n and T_P they should be real words, I think.

> Source/WebKit2/UIProcess/API/gtk/WebKitPrivate.h:74
> +#define _WEBKIT_DEFINE_TYPE_EXTENDED_BEGIN(TypeName, type_name, TYPE_PARENT, flags) \

Instead of using TypeName, type_name, TYPE_PARENT, how about typeName, underscoredTypeName, parentType, flags?

>> Source/WebKit2/UIProcess/API/gtk/WebKitPrivate.h:106
>> +                                          g_intern_static_string(#TypeName), \
> 
> Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]

Please follow the style rule here as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.