[Webkit-unassigned] [Bug 99706] MIPS LLInt implementation.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99706


Oliver Hunt <oliver at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #169392|review?                     |review+
               Flag|                            |




--- Comment #8 from Oliver Hunt <oliver at apple.com>  2012-10-18 09:57:24 PST ---
(From update of attachment 169392)
View in context: https://bugs.webkit.org/attachment.cgi?id=169392&action=review

r=me, but it would be nice if you could respond to my comments :D

> Source/JavaScriptCore/llint/LLIntOfflineAsmConfig.h:126
> +    ".set noreorder\n" \

Quick question, what does this do?  Disable instruction reordering, or disable function reordering - LLInt should be safe against function reordering so if it's the latter this is probably unnecessary.  If it's not then just ignore me :D

> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:163
> +        move sourceRegister, lr

I feel that we should just have 
if C_LOOP or ARMv7 or MIPS
    move sourceRegister, lr
elsif X86 or X86_64
     ...
else
    error
end

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.