[Webkit-unassigned] [Bug 99150] [BlackBerry] Dump DRT output to stdout if test is passed as command line argument

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99150





--- Comment #6 from Rob Buis <rwlbuis at gmail.com>  2012-10-18 09:09:46 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 168614 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=168614&action=review
> > 
> > Patch is ok, but runFromCommandLine functionality should be put into a function.
> > 
> > > Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:224
> > > +    if (runFromCommandLine) {
> > 
> > I talked with Ming and we think it is nicer if this is a method instead, which does the getenv internally.
> 
> It's a little bit complicated to create a new function in DumpRenderTree for runFromCommandLine and call it from main.cpp directly. We need to go through libwebview and several places in webkit to call into DumpRenderTree.cpp. The setenv/getenv solution is much easier. The environment variable drtTestFile has two meanings: 1 - the test to run; 2 - it indicates the test is being run from commandline and we should dump text to stdout instead of redirecting to the dump file.
> I talked with Ming about this today, and he agreed with me.

You are right, the patch is fine as it is.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.