[Webkit-unassigned] [Bug 96784] [GTK] Don't use the C API internally in WebKitSettings

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 18 06:31:48 PDT 2012


--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-10-18 06:32:42 PST ---
(From update of attachment 168891)
View in context: https://bugs.webkit.org/attachment.cgi?id=168891&action=review

>> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:-1105
>> -    ASSERT(!priv->userAgent.isNull());
> Shouldn't you keep the ASSERT?

I think it's impossible to happen, user-agent is a construct property, and when passing NULL it's initialized to the default user agent, so at this point, if we have a valid a WebKitSettings object, userAgent can't be NULL.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list