[Webkit-unassigned] [Bug 96777] [GTK] Don't use the C API internally in WebKitFormSubmissionRequest

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 18 04:59:14 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=96777





--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-10-18 05:00:08 PST ---
(In reply to comment #5)
> (From update of attachment 168889 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=168889&action=review
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitFormSubmissionRequestPrivate.h:26
> > +using namespace WebKit;
> 
> I believe the coding style advises against this kind of thing, see the section about the 'using' directive. So not sure if you are just missing some include here or need to qualify the types directly.

Yes, you are right, I already agreed with Martin to fix all of those in one step once all the patches have landed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list