[Webkit-unassigned] [Bug 98989] [CSS Shaders] Add CustomFilterRenderer to reuse this class by Accelerated Compositing.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98989





--- Comment #8 from Huang Dongsung <luxtella at company100.net>  2012-10-18 03:30:09 PST ---
(In reply to comment #4)
> (From update of attachment 168138 [details])
> I would remove the dependency on the CustomFilterOperation. Most probably the platform code has no access to it. Anyway, FECustomFilter had no dependency on that, so please remove it.

Done.

> nit: typo css1 -> css3

Done.

> This layer should not use the CustomFilterOperation directly. I would rather keep the same constructor as the FECustomFilter had before.

Done.

> > Source/WebCore/platform/graphics/filters/CustomFilterRenderer.cpp:148
> > +bool CustomFilterRenderer::render(Uint8ClampedArray* source, Uint8ClampedArray* destination, const IntSize& size)
> 
> I think this one could have a better name to explain that it would read back the pixels. I suppose at some point you will add one to execute only on textures, so that the Accelerated Pipeline doesn't read back.

The previous patch had made FECustomFilter delegate uploading texture, rendering, managing fbo and reading back pixel to CustomFilterRenderer. However, this patch only delegates rendering css shaders to CustomFilterRenderer because Accelerated Compositing needs CustomFilterRenderer only to render css shaders.
FECustomFilter has jobs:  uploading texture, managing fbo and reading back pixel as it has done. CustomFilterRenderer::paint will be used by both FECustomFilter and Accelerated Compositing.

> I know you just copy-pasted this one, but it seems like NO_INPUT_TEXTURE is never used. Can you please remove CustomFilterDrawType type? I think it was intended to help implementing a renderer that has the input already as a texture instead of just some bytes in the memory.
> 
> For the accelerated compositor you will need a different render method that will take a source texture ID and a destination texture ID, so maybe we could add it back in a different form at that time.

Done.

> I think FECustomFilter should create its own CustomFilterRenderer and not be passed one. CustomFilterRenderer would then be just an implementation detail.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.