[Webkit-unassigned] [Bug 99150] [BlackBerry] Dump DRT output to stdout if test is passed as command line argument

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99150


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #168614|review?                     |review-
               Flag|                            |




--- Comment #4 from Rob Buis <rwlbuis at gmail.com>  2012-10-17 11:40:48 PST ---
(From update of attachment 168614)
View in context: https://bugs.webkit.org/attachment.cgi?id=168614&action=review

Patch is ok, but runFromCommandLine functionality should be put into a function.

> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:224
> +    if (runFromCommandLine) {

I talked with Ming and we think it is nicer if this is a method instead, which does the getenv internally.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.