[Webkit-unassigned] [Bug 99592] Add WebGraphicsContext3D::WebGraphicsUpdateVSyncTimeCallbackCHROMIUM

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 17 11:14:05 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=99592





--- Comment #1 from Brian Anderson <brianderson at chromium.org>  2012-10-17 11:14:57 PST ---
(From update of attachment 169172)
View in context: https://bugs.webkit.org/attachment.cgi?id=169172&action=review

> Source/Platform/chromium/public/WebGraphicsContext3D.h:147
> +        virtual void onUpdateVSyncTime(int64_t) = 0;

Can you use a more descriptive variable name so we know what the units are?
Do you need two arguments (one for phase and one for frequency)?

Also, other parts of the code have started moving towards base::TimeTicks and base::TimeDeltas.  I'm not sure those are allowed in WebGraphicsContext3D.h though.  If they are, we should use those instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list