[Webkit-unassigned] [Bug 77854] [Gtk] XMLHttpRequest modified during onreadystatechange handler

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77854


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #169167|review?                     |review-
               Flag|                            |




--- Comment #9 from Alexey Proskuryakov <ap at webkit.org>  2012-10-17 08:49:31 PST ---
(From update of attachment 169167)
View in context: https://bugs.webkit.org/attachment.cgi?id=169167&action=review

r- for lack of ChangeLog, test cases, and for broken regression test.

I do not understand how this Gtk-only bug has come to modify cross-platform behavior. Could you please explain that in more detail?

> Source/WebCore/xml/XMLHttpRequest.cpp:1024
> +    // From the http://www.w3.org/TR/XMLHttpRequest/#the-status-attribute:
> +    // If the error flag is set, return 0 and terminate these steps.

This comment is not very helpful. It just describes what the code below does, and provides a link to XHR spec.

First, anyone working on this code would know where the spec is anyway. But also, matching an ancient version of the spec will not be relevant five years from now. We make such behavior decisions based on multiple factors, including spec compliance, and our own compatibility testing. The desired behavior is captured in regression tests, not in code comments, unless there is something exceptionally interesting to say.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.