[Webkit-unassigned] [Bug 96769] [GTK] Don't use the C API internally in WebKitBackForwardList

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96769





--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-10-17 08:46:25 PST ---
(In reply to comment #6)
> (From update of attachment 166481 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=166481&action=review
> 
> >>> Source/WebKit2/UIProcess/API/gtk/WebKitBackForwardList.cpp:58
> >>> +    WebBackForwardList* webList;
> >> 
> >> I would probably name it backForwardList instead of webList. But I'm not genius choosing names either, so take it as a subjective opinion.
> > 
> > This was wkList before, I think, I renamed to webList to avoid confusion with C API variables.
> 
> How about naming it items or backForwardItems? backForwardList is a bad name I think because it's the name of the object that holds this private structure in most cases. This is the list of backForwardItems.

Sure!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.