[Webkit-unassigned] [Bug 96769] [GTK] Don't use the C API internally in WebKitBackForwardList

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96769


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #166481|review?                     |review+
               Flag|                            |




--- Comment #6 from Gustavo Noronha (kov) <gns at gnome.org>  2012-10-17 05:33:21 PST ---
(From update of attachment 166481)
View in context: https://bugs.webkit.org/attachment.cgi?id=166481&action=review

>>> Source/WebKit2/UIProcess/API/gtk/WebKitBackForwardList.cpp:58
>>> +    WebBackForwardList* webList;
>> 
>> I would probably name it backForwardList instead of webList. But I'm not genius choosing names either, so take it as a subjective opinion.
> 
> This was wkList before, I think, I renamed to webList to avoid confusion with C API variables.

How about naming it items or backForwardItems? backForwardList is a bad name I think because it's the name of the object that holds this private structure in most cases. This is the list of backForwardItems.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.