[Webkit-unassigned] [Bug 97427] [EFL][DRT] Support Geolocation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=97427





--- Comment #2 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-10-16 19:26:06 PST ---
(From update of attachment 169071)
View in context: https://bugs.webkit.org/attachment.cgi?id=169071&action=review

As you know, WK2 is important for us. Will you support geolocation for WK2 as well ?

> Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:763
> +    mock->reset();

To avoid unused parameter build warning when geolocation is disabled, you need to use UNUSED_PARAM macro as below,

#else
    UNUSED_PARAM(ewkView)
#endif

> Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:774
> +#endif

ditto.

> Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:784
> +#endif

ditto.

> Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:794
> +#endif

ditto.

> Tools/DumpRenderTree/efl/TestRunnerEfl.cpp:372
> +        view = browser->extraViews().last();

Why do you only test last view when there are multiple views ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.