[Webkit-unassigned] [Bug 99485] [EFL][WK2][AC] Url bar should not be covered by the web view

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 16 13:30:06 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=99485





--- Comment #3 from Yael <yael.aharon.m at gmail.com>  2012-10-16 13:30:56 PST ---
(In reply to comment #2)
> (From update of attachment 168992 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=168992&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:688
> > +        needsNewSurface = priv->evasGlSurface;
> 
> Here flag is set under USE(COORDINATED_GRAPHICS) condition.
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:707
> > +    if (needsNewSurface) {
> 
> And here it is used under USE(ACCELERATED_COMPOSITING) .
> I would move assignment out of USE(COORDINATED_GRAPHICS) at least.

I kept the flags as they are now. IMO, we should stick to one flag throughout the code, but I don't think that cleaning out the flags should be part of this patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list