[Webkit-unassigned] [Bug 99488] Fix a bug that we are using scaled damage rect for plugins inside an iframe

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99488


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #169000|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #3 from Adam Barth <abarth at webkit.org>  2012-10-16 13:12:23 PST ---
(From update of attachment 169000)
View in context: https://bugs.webkit.org/attachment.cgi?id=169000&action=review

Can we write a test for this change?

> Source/WebKit/chromium/src/WebPluginContainerImpl.cpp:142
>      IntRect windowRect =
> -        IntRect(view->contentsToWindow(enclosingIntRect(scaledDamageRect)));
> +        IntRect(view->contentsToWindow(enclosingIntRect(scaledDamageRect).location()), enclosingIntRect(scaledDamageRect).size());

Can we change this to only call enclosingIntRect(scaledDamageRect) once?  Also, there's no reason to have a line break after the =

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.