[Webkit-unassigned] [Bug 98728] [Texmap] Swizzling BGRA to RGBA in temp buffer while USE(TEXMAP_OPENGL_ES_2)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98728


Noam Rosenthal <noam.rosenthal at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #168839|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #11 from Noam Rosenthal <noam.rosenthal at nokia.com>  2012-10-16 08:43:49 PST ---
(From update of attachment 168839)
View in context: https://bugs.webkit.org/attachment.cgi?id=168839&action=review

This is getting closer - however this should be an enum that gets passed along updateContents, not a bool member; Also this is not about directly composited images, it's about whether BitmapTexture is allowed to modify the original image. Something like enum UpdateContentsFlag { UpdateCanModifyOriginalImageData = 0x01 }

> Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.cpp:76
> +void TextureMapperTile::updateContents(TextureMapper* textureMapper, Image* image, const IntRect& dirtyRect, bool isDirectlyCompositedImage)

This is a boolean trap... it should be an enum, like ContentUpdateOptions

> Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.cpp:98
> +    if (isDirectlyCompositedImage)
> +        m_texture->setDirectlyCompositedFlag();
>      m_texture->updateContents(image, targetRect, sourceOffset);
> +    if (isDirectlyCompositedImage)
> +        m_texture->resetDirectlyCompositedFlag();

You don't really need this as a member. Pass it through the updateContents functions instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.