[Webkit-unassigned] [Bug 97859] [CSS Shaders] Implement all composite operators except destination and lighter.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=97859





--- Comment #38 from Max Vujovic <mvujovic at adobe.com>  2012-10-15 15:05:30 PST ---
(From update of attachment 168535)
Thanks for investigating the issue!

View in context: https://bugs.webkit.org/attachment.cgi?id=168535&action=review

> Source/WebCore/ChangeLog:19
> +            Remove ASSERTION checking if glGetUniformlocation returns negative,

Nit: Capitalization "glGetUniformLocation".

> Source/WebCore/ChangeLog:24
> +            glGetuniformlocation returns -1. glGetAttribLocation ditto.

Ditto.

> Source/WebCore/platform/graphics/filters/CustomFilterCompiledProgram.cpp:-139
> -        ASSERT(m_samplerLocation != -1);

This assertion is nice because it can catch bugs in the shader rewriting, so I'm not sure we should remove it.

Perhaps we can move this assertion to:
CustomFilterValidatedProgram::compiledProgram()

And it can look like this:
ASSERT(m_samplerLocation != -1 || !needsInputTexture());

Calling a new method:
bool CustomFilterValidatedProgram::needsInputTexture() const
{
     return m_programInfo.programType == PROGRAM_TYPE_BLENDS_ELEMENT_TEXTURE
          && m_programInfo.compositeOperator != CompositeClear 
          && m_programInfo.compositeOperator != CompositeCopy;
}

I'm suggesting moving it CustomFilterValidatedProgram because CustomFilterCompiledProgram doesn't know about compositing operators. It only knows about the GLSL shader strings it should to compile.

What do you think?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.