[Webkit-unassigned] [Bug 98874] [GTK] WebKitWebView doesn't notify of favicon changes for known favicons but new pages

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98874





--- Comment #13 from Mario Sanchez Prada <mario at webkit.org>  2012-10-15 11:36:08 PST ---
(In reply to comment #12)
> Created an attachment (id=168732)
 --> (https://bugs.webkit.org/attachment.cgi?id=168732&action=review) [details]
> Updated patch
> 
> Patch updated to add a change suggested by Mario, because unit tests didn't
> pass for him. The idea is to wait until there's an icon record in the database
> to emit favicon-changed. For some reason I don't need this to make unit tests
> pass, but it's a good idea in any case.

Thanks. I've tested this patch locally and I can confirm it works fine for me, at least in the cases I've tried it out so far (running TestWebKitFavicons and testing my patches for epiphany with it)

So, it looks good to me, but some formal reviewer should bless it anyway. Any takers? Gustavo? Martin? Xan?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.