[Webkit-unassigned] [Bug 97651] [EFL] Make PageClient accessible to both WebKit and WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=97651





--- Comment #5 from Regina Chung <heejin.r.chung at samsung.com>  2012-10-15 00:20:50 PST ---
(In reply to comment #3)
> (From update of attachment 168381 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=168381&action=review
> >> Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:63
> >> +                sharedContext = static_cast<Evas_GL_Context*>(context->platformGraphicsContext3D());
> > 
> > Can I know the meaning of this?
> > 
> > I could not find usage of this value.
> Better question (answer in changelog) why is this different code path needed for webkit1? Could it use the same one as webkit2 (fake evas) or is there any advantages to this new approach?

In WebKit2 a GraphicsContext3D is created for Accelerated Compositing(AC), and another for WebGL (if needed). 
When creating the evas gl context for WebGL we create it as a shared context with ACs evas gl context, so we can use the evas created for webview for both of them.
Thus no need for a fake evas.

> > Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:119
> > +bool GraphicsContext3DPrivate::createSurface(WebPageClientEfl* pageClient, bool renderDirectlyToHostWindow)
> Why not adding the actual Evas_Object* instead? There is like almost nothing shared in WebPageClientEfl

PageClientEfl (which is only used for webkit1) also provides a way to access ewk_view_*** calls from GraphicsContext3D.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.